On Mon, Feb 26, 2018 at 3:35 AM, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > My recently landed wildmatch test series was in preperation for some > more major wildmatch changes. > > Here's another series that prepares for bigger changes in wildmatch, > it adds an interface to pre-compile the patterns. Right now there's no > point in doing this, and it's harmless since none of the codepaths are > that performance sensitive, but down the line this'll save us time as > we'll be able to skip re-parsing the pattern each time with a better > wildmatch backend. I don't see any big problem with this, but should this be a standalone series? Some changes look harmless now, but I'd rather see the real precompile implementation to see how it impacts (or benefits) the converted call sites. -- Duy
