Junio C Hamano <junkio@xxxxxxx> wrote: > Good job. I actually almost like it. Heh. Thanks. I almost like it to. I like what it does for the non-V=1 formatting, as I think its easier to read the installation process. But I really don't like that install target. The problem of course is there's no $@ that I can depend on in the install rules, and the rules for the builtins (rm -f && ln) is very very messy. > Without V=1, I get this from 'pu' that merged your 'pu'. > > ... > make -C git-gui install > make[1]: Entering directory `/git/git.git/git-gui' > DEST /home/junio/git-pu/bin > INSTALL 755 git-gui > LINK git-citool -> git-gui > DEST /home/junio/git-pu/share//git-gui/lib > INSTALL 644 tclIndex > INSTALL 644 blame.tcl > INSTALL 644 branch.tcl > INSTALL 644 branch_rename.tcl > INSTALL 644 browser.tcl > ... Right. I wanted to try and keep the lines very simple, like we have with our CC/GEN/BUILTIN lines. But I also wanted to be clear about which directories we are dropping stuff into. > And with V=1, what I see seem very readable. Right. My target there was that the V=1 case was *exactly* what I had before. Because a simple installation with no pretty formatting should be exactly that; a simple installation with no pretty formatting. -- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
