On Sat, Feb 24, 2018 at 5:17 AM, brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: > On Fri, Feb 23, 2018 at 04:56:39PM +0700, Nguyễn Thái Ngọc Duy wrote: >> [3] the reason server side is still running ok with no hash algo >> before [2] is because the programs that use enter_repo() do very >> little then spawn a new program (like pack-objects or >> upload-archive) to do the heavy lifting. These programs already >> use setup_git_dir..() > > You have "..()" here. Did you want to say "()." instead? It's because we have two functions, setup_git_directory() and setup_git_directory_gently() and I tend to just put '*' instead of listing both. But since it causes confusion, I'm listing both in v2. -- Duy
