On Fri, Feb 23, 2018 at 03:47:55PM +0100, Rasmus Villemoes wrote: > Changes in v2: > > - Drop patch 3 with dubious gain/complexity ratio > - Add comments regarding ownership of grep_source > > I was a little torn between copy-pasting the comment or just saying > "see above" in the second case. I think a memset would be confusing, > at least unless one extends the comment to explain why one then does > the memset despite the first half of the comment. This looks good to me. Thanks for following up. -Peff
