Frank Lichtenheld wrote: > On Fri, Jun 01, 2007 at 05:52:53PM -0700, Josh Triplett wrote: >> Frank Lichtenheld wrote: >>> On Fri, Jun 01, 2007 at 03:20:52PM -0700, Josh Triplett wrote: >>>> + - Otherwise, git treats the pattern as a shell glob suitable >>>> + for consumption by fnmatch(3) with the FNM_PATHNAME flag: any >>>> + slash in the pattern must match a slash in the pathname. For >>>> + example, "Documentation/\*.html" matches >>>> + "Documentation/git.html" but not "ppc/ppc.html". A leading >>>> + slash matches the beginning of the pathname; for example, >>>> + "/*.c" matches "cat-file.c" but not "mozilla-sha1/sha1.c". >>> I realise this is copy&paste but shouldn't that read: >>> "Documentation/\*.html" matches "Documentation/git.html" >>> but not "Documentation/ppc/ppc.html" >>> ? >> I don't know. Neither file seems to exist in current Git. > > The point I was trying to make is that "Documentation/*.html" _of > course_ doesn't match ppc/ppc.html. What we try to tell the user here > is that * doesn't match / > So I think it should definetly read Documentation/ppc/ppc.html Ah, I understand your point now. > FWIW, I find the sentence > "any slash in the pattern must match a slash in the pathname" > very confusing too. The sentence in fnmatch(3) is much more precise: > "match a slash in string only with a slash in pattern and not by an > asterisk (*) or a question mark (?) metacharacter, nor by a bracket > expression ([]) containing a slash" I like that better as well. > Anyway, if you prefer (and if it is okay with Junio) I can send a > patch of my own for this single issue to not hinder the commit of > your big patch as the issue is equally present in the old and the > new text. Now that I understand the issue you raised, I can easily fix it and send a revised patch. Expect one momentarily. - Josh Triplett
Attachment:
signature.asc
Description: OpenPGP digital signature
