On 19 February 2018 at 22:29, Jeff King <peff@xxxxxxxx> wrote: > On Wed, Feb 14, 2018 at 10:56:37PM +0100, Martin Ågren wrote: > >> Here's what a list of known leaks might look like. It feels a bit >> awkward to post a known-incomplete list (I don't run all tests). Duy >> offered to pick up the ball if I gave up, maybe you could complete and >> post this as your own? :-? Even if I (or others) can't reproduce the >> complete list locally, regressions will be trivial to find, and newly >> leak-free tests fairly easy to notice. > > I didn't think about that when I posted my scripts. In general, it's OK > to me if you miss a script when you generate the "leaky" list. But if > you skip it, you cannot say whether it is leaky or not, and should > probably neither add nor remove it from the known-leaky list. So I think > the second shell snippet needs to become a little more clever about > skipped test scripts. > > Even that isn't 100% fool-proof, as some individual tests may be skipped > or not skipped on various platforms. But it may be enough in practice > (and eventually we'd have no known-leaky tests, of course ;) ). All good points. > Or alternatively, we could just not bother with checking this into the > repository, and it becomes a local thing for people interested in > leak-testing. What's the value in having a shared known-leaky list, > especially if we don't expect most people to run it. This sums up my feeling about this. > I guess it lets us add a Travis job to do the leak-checking, which might > get more coverage. So maybe if we do have an in-repo known-leaky, it > should match some canonical Travis environment. That won't give us > complete coverage, but at this point we're just trying to notice > low-hanging fruit. Right. A Travis job to get non-complete but consistent data would be "nice" (TM), but at this point it would perhaps just result in blacklist-churning. At some point, adding/removing entries in a blacklist will have some signal-value and psychology to it, but right now it might just be noise. (My patch adds an incomplete blacklist of 539 scripts...) For finding this sort of low-hanging fruit (windfall?) any local scripting and greping will do. I sort of hesitate wasting community CPU cycles on something which might be appreciated, in theory, but that doesn't have enough attention to move beyond "every now and then, something is fixed, but just as often, tests gain leaks and the blacklist gains entries". To sum up: I probably won't be looking into Travis-ing such a blacklist in the near future. Martin
