On Wed, Feb 14 2018, Jonathan Nieder jotted: > Ævar Arnfjörð Bjarmason wrote: > >> --- a/perl/Git.pm >> +++ b/perl/Git.pm >> @@ -1324,8 +1324,9 @@ sub _temp_cache { >> } >> >> sub _verify_require { >> - eval { require File::Temp; require File::Spec; }; >> - $@ and throw Error::Simple($@); >> + require File::Temp; >> + require File::Spec; >> + return; > > Same question as in the other patches: any reason not to simplify by > using 'use' at the top of the file instead? I was just going for the minimal change, but yeah, that makes sense. Will do that in v2.