On Tue, Feb 13, 2018 at 11:22 PM, Jeff King <peff@xxxxxxxx> wrote: >> for i in "--perl --shell" "-s --python" "--python --tcl" "--tcl --perl"; do >> test_expect_success "more than one quoting style: $i" " >> - git for-each-ref $i 2>&1 | (read line && >> - case \$line in >> - \"error: more than one quoting style\"*) : happy;; >> - *) false >> - esac) >> + test_must_fail git for-each-ref $i 2>err && >> + grep '^error: more than one quoting style' err > > I suspect in the long run this ought to be test_i18ngrep, but since it's > not localized yet, it makes sense to stop here with this patch. I thought 'git for-each-ref' is plumbing and that means that it shouldn't be localized.