2018-02-15 8:40 GMT+03:00 Jeff King <peff@xxxxxxxx>: > On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote: > >> Moving from using expand_data to ref_array_item structure. >> That helps us to reuse functions from ref-filter easier. > > This one feels weird. The point of a ref_array_item is for the caller to > feed data into the ref-filter formatting code (usually that data comes > from an earlier call to filter_refs(), but in the new cat-file we'd > presumably feed single items). > > But here we're adding a bunch of fields for items that we'd expect the > format code to compute itself. It would be changed later, it's just the addition of new structure that we have never used in cat-file before. > > -Peff
