Ævar Arnfjörð Bjarmason wrote:
> Update our copy of Mail::Address from 2.19 (Aug 22, 2017) to 2.20 (Jan
> 23, 2018). This should be a trivial update[1] but it seems the version
> Matthieu Moy imported in bd869f67b9 ("send-email: add and use a local
> copy of Mail::Address", 2018-01-05) doesn't correspond to any 2.19
> version found on the CPAN. From the comment at the top of the file it
> looks like some OS version with the POD stripped, and with different
> indentation.
Were there changes other than the POD stripping?
> Let's instead use the upstream version as-is, and without copyright
> notices stripped. Like Error.pm this doesn't cleanly pass --check, so
> add a .gitattributes file to ignore the errors.
>
> 1. https://metacpan.org/diff/file?target=MARKOV/MailTools-2.20/lib%2FMail%2FAddress.pod&source=MARKOV%2FMailTools-2.19%2Flib%2FMail%2FAddress.pod
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
> ---
> perl/Git/FromCPAN/Mail/.gitattributes | 1 +
> perl/Git/FromCPAN/Mail/Address.pm | 436 +++++++++++++---------------------
> 2 files changed, 163 insertions(+), 274 deletions(-)
> create mode 100644 perl/Git/FromCPAN/Mail/.gitattributes
Yikes re the stripped POD with license notice. Thanks for fixing it.
Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
