Re: [PATCH] Unify write_index_file functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 1 Jun 2007, Dana How wrote:

> (2) write_idx_file has a sha1 argument with different in & out meanings,
> requiring copies at some call sites.  Should this be 2 separate args?

I think the copy could be avoided entirely.  The pack_file_sha1 array 
doesn't need to have global scope.  The simple sha1[20] array with this 
patch can serve the pack_file_sha1 purpose as well just fine.


Nicolas
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux