Ismail Dönmez <ismail@xxxxxxxxxxxxx> writes:
> On Friday 01 June 2007 22:44:36 Junio C Hamano wrote:
>> Alexandre Julliard <julliard@xxxxxxxxxx> writes:
>> > Sorry for the late nack, but it turns out that this patch breaks diff
>> > output on the Wine server for files that are not utf-8.
>> >
>> > The cause is apparently that decode_utf8() returns undef for invalid
>> > sequences instead of substituting a replacement char like
>> > decode("utf8") does.
>>
>> Thanks for noticing. Will revert.
>
> Why are reverting a correct bugfix? :( He's at most using outdated software.
> *sigh*
I would assume that on top of a revert, with an additional
return $str if is_utf8($str);
to to_utf8() you should be able to fix both installations that
has old or new Encode.pm?
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
