Alexander Shopov <ash@xxxxxxxxxxxxxx> writes: > Small changes in messages to fit the style and typography of rest > Reuse already translated messages if possible > Do not translate messages aimed at developers of git > Fix unit tests depending on the original string > Use `test_i18ngrep` for tests with translatable strings > Change and verifyrest of tests via `make GETTEXT_POISON=1 test` Perhaps end each sentence with a full-stop? > diff --git a/t/t0002-gitfile.sh b/t/t0002-gitfile.sh > index 9670e8cbe..797dcf95b 100755 > --- a/t/t0002-gitfile.sh > +++ b/t/t0002-gitfile.sh > @@ -31,7 +31,7 @@ test_expect_success 'bad setup: invalid .git file format' ' > echo "git rev-parse accepted an invalid .git file" > false > fi && > - if ! grep "Invalid gitfile format" .err > + if ! test_i18ngrep "invalid gitfile format" .err Shouldn't this rather be like so instead? if test_i18ngrep ! "invalid gitfile format" .err Ditto for the other negated use of test_i18ngrep we see in the same file in this patch.
