Re: [PATCH] send-email: error out when relogin delay is missing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 8, 2018 at 1:21 PM, Stefan Beller <sbeller@xxxxxxxxxx> wrote:
> On Thu, Feb 8, 2018 at 12:08 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
>> On Wed, Feb 7, 2018 at 6:43 PM, Stefan Beller <sbeller@xxxxxxxxxx> wrote:
>>> +die __("When a batch size is given, the relogin delay must be set\n")
>>> +       if defined $relogin_delay and not defined $batch_size;
>>
>> This only makes sense is 'batch-size' is specified but not 'relogin'.
>> If the other way around, then the error is confusing. How about this
>> instead?
>>     "--batch-size and --relogin must be specified together"
>> ...or something.
>
> I like this for its expressiveness as it would have helped me a lot.
> I dislike this because it is incorrect when you use the config options
> instead of command line arguments.

Perhaps:

    "`batch-size` and `relogin` must be specified together
      (via command-line or configuration option)"



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux