On Thu, Feb 08, 2018 at 01:47:50PM -0500, Jon Simons wrote: > The packet_read_line() function will die if it sees any > protocol or socket errors. But it will return NULL for a > flush packet; some callers which are not expecting this may > dereference NULL if they get an unexpected flush. This would > involve the other side breaking protocol, but we should > flag the error rather than segfault. As one might guess from the dual authorship on this series, Jon and I discussed these off list. So this one is Reviewed-by: Jeff King <peff@xxxxxxxx> And the other one, too, but I'm not sure that carries any weight. :) -Peff
