Junio C Hamano <gitster@xxxxxxxxx> writes: >>> This was a bit painful change, given that some changes in flight do >>> add new callsites to read_index_from() and they got the function >>> changed under their feet. >> >> Sorry about that. Is there any way to make such a change less painful >> in the future? > > One way is to do for read_index_from() what you did for the existing > users of read_cache_from(). Introduce a _new_ helper that will not > be known for any existing topics in flight, and use that to make the > existing API a thin wrapper around it. This continues to cause pain simply because read_index_from() is something new topics want to stay stable X-<. I'll be merging this to 'next' hopefully as part of today's integration run, so will need to endure the pain only until it (and other topics that conflict with it) all graduate to 'master'. Next time a patch with an internal API change like this appears, please remind me to push it back a lot stronger. I was too lenient and ended up slowing down the progress of other topics this time. Thanks.
