On Mon, Feb 5, 2018 at 6:20 PM, brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Feb 05, 2018 at 03:55:37PM -0800, Stefan Beller wrote: >> The ref subsystem has not been migrated yet to access the object store >> via passed in repository objects. As a result replace when the object store >> tries to access replace refs in a repository other than the_repository >> it produces errors: >> >> error: refs/replace/3afabef75c627b894cccc3bcae86837abc7c32fe does not point to a valid object! >> >> Add a test demonstrating this failure. >> >> Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx> >> Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> >> >> squash! push: add test showing bad interaction of replace refs and submodules >> >> replace-objects: evaluate replacement refs without using the object store >> >> Pass DO_FOR_EACH_INCLUDE_BROKEN when iterating over replacement refs >> so that the iteration does not require opening the named objects from >> the object store. This avoids a dependency cycle between object access >> and replace ref iteration. >> >> Moreover the ref subsystem has not been migrated yet to access the object >> store via passed in repository objects. As a result, without this patch >> when the object store tries to access replace refs in a repository other >> than the_repository it produces errors: >> >> error: refs/replace/3afabef75c627b894cccc3bcae86837abc7c32fe does not point to a valid object! >> >> Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx> >> Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> > > It appears you have multiple independent commit messages here. I will drop this patch; it appears as if it was targeted to be part of 006f3f28af (replace-objects: evaluate replacement refs without using the object store, 2017-09-12), which landed. We can revive this test outside of this long series if we feel inclined. Thanks for spotting! Stefan
