Hi Phillip, On Wed, 24 Jan 2018, Phillip Wood wrote: > diff --git a/sequencer.h b/sequencer.h > index 24401b07d57b7ca875dea939f465f3e6cf1162a5..e45b178dfc41d723bf186f20674c4515d7c7fa00 100644 > --- a/sequencer.h > +++ b/sequencer.h > @@ -1,6 +1,7 @@ > #ifndef SEQUENCER_H > #define SEQUENCER_H > > +const char *git_path_commit_editmsg(void); > const char *git_path_seq_dir(void); > > #define APPEND_SIGNOFF_DEDUP (1u << 0) I would rather have stuck this into `commit.h` and `commit.c`, but it does not really matter all that much. The rest looks good (if a little verbose on the test front, I think testing just the cherry-pick would have exercised the code path enough). All three patches are Reviewed-by: me. Ciao, Dscho
