On Sun, Jan 28, 2018 at 02:50:18PM -0500, Eric Sunshine wrote: > On Sun, Jan 28, 2018 at 10:57 AM, brian m. carlson > <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: > > Convert various uses of direct calls to SHA-1 and 20- and 40-based > > constants to use the_hash_algo instead. Don't yet convert the on-disk > > data structures, which will be handled in a future commit. > > > > Signed-off-by: brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> > > --- > > diff --git a/read-cache.c b/read-cache.c > > @@ -2000,26 +2000,26 @@ static int write_index_ext_header(git_SHA_CTX *context, int fd, > > /* Flush first if not enough space for SHA1 signature */ > > Did you want to update the comment to remove the SHA1 reference also? > (Or was the omission intentional per the commit message?) These weren't intentional, so I'll fix them in a reroll. The only reason I didn't touch the ondisk data structures is because they're directly mmap'd. So if I change them to use struct object_id, as soon as we expand the structure size, the ondisk structures become unusable. Some sort of union hack or multiple subroutines will probably be required. -- brian m. carlson / brian with sandals: Houston, Texas, US https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
