Re: [PATCH 05/14] packed-graph: implement construct_graph()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Stefan Beller <sbeller@xxxxxxxxxx> writes:

> On Thu, Jan 25, 2018 at 6:02 AM, Derrick Stolee <stolee@xxxxxxxxx> wrote:
>
>> +struct object_id *construct_graph(const char *pack_dir)
>> +{
>> +       // Find a list of oids, adding the pointer to a list.
>
> Comment style.
> Here is where the bike shedding begins. ;)

I also saw some violations of the usual formatting conventions, e.g.

	if (condition) {
		block

should not be

	if (condition)
	{
		block




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux