Re: [PATCH] Don't ignore write failure from git-diff, git-log, etc.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, 29 May 2007, Jim Meyering wrote:
> >
> > Maybe you have not noticed, but my argument has ben about EPIPE.
> 
> Ha ha.  That's a good one.
> The point was that even you must see that your
> "[Jim's] WHOLE patch is crap" statement was wrong.

Ehh. That's a rather edited version of what I said, isn't it?

That's after I explicitly _quoted_ the part where you actively removed the 
code that said "EPIPE is right", and also after I had told you several 
times that you should consider EPIPE as a special case in your other part.

In other words, yes, EVERY SINGLE HUNK of your patch was wrong, and I had 
told you exactly why.

How wrong does a patch have to be to be "crap"? Maybe I have higher 
standards than you do (apparently so), but "every single hunk was wrong" 
should certainly be a damn good reason to consider _any_ patch crap, 
wouldn't you say?

And now you have trouble accepting that, even after you have sent out a 
fixed patch without the crap. Thanks for finally bothering to get the 
patch right, but I don't see why you have to try to make-believe that it 
was ever about anything but EPIPE.

So go back and read my emails. You'll see that in every single one I made 
it very clear that EPIPE was special. From the very first one (where I 
didn't call your patch crap, btw: I said it was wrong, and that some 
errors are expected and good, and I explicitly told you about EPIPE).

So what did you do? Instead of acknowledging that EPIPE was different, you 
actually *expanded* on that original patch, and made the other places 
where we _did_ handle EPIPE correctly, and made those places handle it 
_incorrectly_.

And then you expect me to be _polite_ about it? Grow up. I was polite 
before you started explicitly doing the reverse of what I told you you 
should do. At that point, your patch went from "meant well, but the patch 
was wrong" to "That's just obviously crap".

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux