On Fri, Jan 26, 2018 at 10:19:17AM -0800, Junio C Hamano wrote: > SZEDER Gábor <szeder.dev@xxxxxxxxx> writes: > > > Both 'test_i18ncmp' and 'test_i18ngrep' helper functions are supposed > > to be called from our test scripts, so they should be in > > 'test-lib-functions.sh'. > > > > Signed-off-by: SZEDER Gábor <szeder.dev@xxxxxxxxx> > > --- > > t/test-lib-functions.sh | 26 ++++++++++++++++++++++++++ > > t/test-lib.sh | 26 -------------------------- > > 2 files changed, 26 insertions(+), 26 deletions(-) > > Hmph. I do not care too much either way, but I had an impression > that test-lib-functions.sh is meant to be more generic (i.e. those > who want can steal it from us and use it in their project without > dragging too much of the local convention we employ in this project) > than what is in test-lib.sh, which can heavily be specific to Git, > and I also had an impression that gettext-poison build is quite a > local convention we use in this project, not applicable to other > people. I had a similar notion, but I thought it was the other way around: test-lib.sh was supposed to be the harness, and test-lib-functions.sh was our own stuff. But I do not think we have really kept to that over the years. TBH I have generally been confused by the distinction and just use ctags to find the right source file. ;) -Peff
