Re: [PATCH 02/14] packed-graph: add core.graph setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/25/2018 4:43 PM, Junio C Hamano wrote:
Derrick Stolee <stolee@xxxxxxxxx> writes:

The packed graph feature is controlled by the new core.graph config
setting. This defaults to 0, so the feature is opt-in.

The intention of core.graph is that a user can always stop checking
for or parsing packed graph files if core.graph=0.

Signed-off-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx>
---
  Documentation/config.txt | 3 +++
  cache.h                  | 1 +
  config.c                 | 5 +++++
  environment.c            | 1 +
  4 files changed, 10 insertions(+)
Before you get too married to the name "graph", is it reasonable to
assume that the commit ancestry graph is the primary "graph" that
should come to users' minds when a simple word "graph" is used in
the context of discussing Git?  I suspect not.

Let's not just call this "core.graph" and "packed-graph", and in
addition give some adjective before "graph".

I was too focused that I wanted the word "graph" but "graph.c" already existed in source root that I came up with "packed-graph.c" just to have a separate filename. Clearly, "commit-graph" should be used instead. In v2, I'll use "/commit-graph.c" and "/builtin/commit-graph.c".

Thanks,
-Stolee



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux