On 24/01/18 20:33, Junio C Hamano wrote: > randall.s.becker@xxxxxxxxxx writes: > >> From: "Randall S. Becker" <rsbecker@xxxxxxxxxxxxx> >> Subject: Re: [PATCH v4 1/4] Add tar extract install options override in installation processing. > > We typically start the subject with some short token to help readers > of "git shortlog --no-merges" identify what area is being touched, > e.g. something like > > Subject: [PATCH 1/4] Makefile: allow customizing tar extract options for installation > >> Introduced TAR_EXTRACT_OPTIONS as a configuration option to change >> the options of tar processing during extract. The default value is "o" >> which synthesizes xof, by default. > > And then we order the codebase "to be like so" (or, give an order to > a patch monkey "to make the resulting code like so"). > i.e. something like: > > Introduce TAR_EXTRACT_OPTIONS to allow customizing the tar > options used when installing. The default value is "o", which ... > > What is missing from the log message is the most important thing, > though. Everything you wrote (i.e. what build-time knob is being > added, what is tweaked and what the default is) we can read from the > patch text itself, but readers will be left wondering why anybody > would want to change "o" and change it to what else under what > circumstances to achieve what. I am guessing something like this > might be the reason behind this change > > This allows an implementations of "tar" that lacks the 'o' > (--no-same-owner) extract option to be used (even though the > resulting installed versions will keep ownership of whoever > happened to have built them, instead of being owned by 'root') > > but please do not make readers guess. Hmm, I'm a bit puzzled by this patch. I may be wrong, but it looks like it has nothing to do with the lack of the 'o' option of tar, and more to do with adding the 'v' option to only a single invocation of tar. There are three instances of this kind of pattern in the Makefile, but only one has been modified. Why? > Having said all that, I wonder if this "go to po/build/locale, tar > everything up and then extract it elsewhere" is truly necessary. > IOW, why isn't it sufficient to do this instead, for example? > > umask 022 && cp -r po/build/locale/. '$(DESTDIR_SQ)$(localedir_SQ)' Given the above, I suspect that (for some unknown reason), a verbose 'listing' of the locale files is required ... :-D ATB, Ramsay Jones
