On 24/01/18 12:34, Phillip Wood wrote: > From: Phillip Wood <phillip.wood@xxxxxxxxxxxxx> > > Commit 356ee4659b ("sequencer: try to commit without forking 'git > commit'", 2017-11-24) forgot to run the 'prepare-commit-msg' hook when > creating the commit. Fix this by writing the commit message to a > different file and running the hook. Using a different file means that > if the commit is cancelled the original message file is > unchanged. Also move the checks for an empty commit so the order > matches 'git commit'. > > Reported-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > Signed-off-by: Phillip Wood <phillip.wood@xxxxxxxxxxxxx> > Reviewed-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> Echoing Eric's earlier email, I don't think this Reviewed-by is warranted - I only requested the addition of a static keyword, I didn't actually review the patch. Thanks. ATB, Ramsay Jones