On Wed, Jan 24, 2018 at 1:02 AM, Jeff King <peff@xxxxxxxx> wrote: > > On Tue, Jan 23, 2018 at 11:54:17PM -0300, Juan F. Codagnone wrote: ... > > > But given the lack of callers, it may not be worth the effort. So I'm OK > with this solution. It may be worth giving an abbreviated version of the > above explanation in the commit message. Perhaps: > > If <msg> or <patch> files can't be opened, then mailinfo() returns an > error before it even initializes mi->p_hdr_data or mi->s_hdr_data. > When cmd_mailinfo() then calls clear_mailinfo(), we dereference the > NULL pointers trying to free their contents. > > As for the patch itself, it looks correct but I saw two style nits: Thanks for the detailed review! I'm sorry about the style nits. I focused on the tabs and braces. Next time I will take additional attention. I'll be resubmitting the patch taking into account your remarks.
