On 20 January 2018 at 21:58, brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: > When I've made changes to the sha1_file functions, I've traditionally > moved them away from using "sha1_file" to "object_file" to ensure that > we make it a bit more obvious that they handle object_id structs and > aren't limited to SHA-1. For consistency, it might be nice to make that > change. I will address this in V2 and add several more conversions, that are sufficient to make git hash-object -w work with sha-256 (which I will send as separate RFC thread). I started converting functions needed for cat-file, but number of places, that still needs to be touched up grew quite rapidly, so it'll take some time :). -- | ← Ceci n'est pas une pipe Patryk Obara