Re: [PATCH v3] mru: Replace mru.[ch] with list.h implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Gargi Sharma <gs051095@xxxxxxxxx> wrote:
> --- a/list.h
> +++ b/list.h
> @@ -93,6 +93,13 @@ static inline void list_move(struct list_head *elem, struct list_head *head)
>  	list_add(elem, head);
>  }
>  
> +/* Move to the front of the list. */
> +static inline void list_move_to_front(struct list_head *elem, struct list_head *head)
> +{
> +	list_del(elem);
> +	list_add(elem, head);
> +}
> +

Since we already have list_move and it does the same thing,
I don't think we need a new function, here.

Hackers coming from other projects (glibc/urcu/Linux kernel)
might appreciate having fewer differences from what they're used
to.

Anyways thanks for working on this!



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux