On Mon, Jan 15, 2018 at 08:46:25PM -0500, Gargi Sharma wrote: > Replace the custom calls to mru.[ch] with calls to list.h. This patch is the > final step in removing the mru API completely and inlining the logic. > > Another discussion, here > (https://public-inbox.org/git/CAOCi2DGYQr4jFf5ObY2buyhNJeaAPQKF8tbojn2W0b18Eo+Wgw@xxxxxxxxxxxxxx/) > was on what has to be done with the next pointer of packed git type > inside the > packed_git structure. It can be removed _given_ that no one needs to > access the list in order and can be sent as another patch. Thanks for picking this up again. I agree that this is probably a good stopping point for now, as I think just combining this with the 'next' pointer may carry more side effects. Aside from the braces thing that Christian mentioned (and the missing signoff), this all looks good to me. -Peff
