On Thu, 18 Jan 2018 15:50:52 +0100 Patryk Obara <patryk.obara@xxxxxxxxx> wrote: > Patch 1 is not directly related to object_id conversions but helped with > debugging t5540, which kept failing on master for me (spoiler: it was Fedora > fault). It helps with debugging of failing git-push over HTTP in case of > internal server error, so I think it might be worthwhile. This patch seems reasonable to me - it is a little strange that, currently, an error message is printed upon an XML error and upon failure of start_active_slot(), but not when the slot cannot be run. This patch fills the gap. > Patch 2 is a small adjustment to .clang-format, which prevents unnecessary > line breaks after function return type. I'm not very familiar with clang-format, so no comment from me here. > Patch 6 is a tiny fix in oidclr function. Ah, good catch. I would write the memset line as "memset(oid, 0, sizeof(*oid))", but the existing one is fine too. > All other patches are progressive conversions to struct object_id with some > formatting fixes sprinkled in. These should be somewhat uncontroversial, I hope. I've looked at those and they appear to be obviously correct.
