On Tue, Jan 16, 2018 at 2:13 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes:
>
>> +test_trace() {
>> + local expected="$1"
>
> Style: "test_trace () {" is how we start a shell function.
> Portability: we do not use "local".
>
>> + shift
>> + GIT_TRACE=1 test-run-command "$@" run-command true 2>&1 >/dev/null | \
>> + sed 's/.* run_command: //' >actual &&
>> + echo "$expected true" >expected &&
>> + test_cmp expected actual
>
> Consistency: everybody else in the test script contrasts "actual" vs
> "expect" (they happen to be of the same length ;-); don't say
> expectED just to be different.
3491 entries in the t/ directory disagree with your imagination of
consistency. ;)
But I agree that we want to go for consistency, and most likely it's
best to go for 'expect'.
