Re: [PATCH v5 3/7] trace.c: move strbuf_release() out of print_trace_line()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v5 3/7] trace.c: move strbuf_release() out of print_trace_line()
From: Brandon Williams <bmwill@xxxxxxxxxx>
Date: Tue, 16 Jan 2018 10:24:32 -0800
Cc: git@xxxxxxxxxxxxxxx, Stefan Beller <sbeller@xxxxxxxxxx>, Junio C Hamano <gitster@xxxxxxxxx>, Jeff King <peff@xxxxxxxx>, Johannes Sixt <j6t@xxxxxxxx>
In-reply-to: <20180115105949.18328-4-pclouds@gmail.com>
References: <20180113064949.6043-1-pclouds@gmail.com> <20180115105949.18328-1-pclouds@gmail.com> <20180115105949.18328-4-pclouds@gmail.com>
User-agent: Mutt/1.5.21 (2010-09-15)

On 01/15, Nguyễn Thái Ngọc Duy wrote:
> The function is about printing a trace line, not releasing the buffer it
> receives too. Move strbuf_release() back outside. This makes it easier
> to see how strbuf is managed.

This makes the code much more readable.

-- 
Brandon Williams

References:
- [PATCH v4 0/7] Trace env variables in run_command()
  - From: Nguyễn Thái Ngọc Duy
- [PATCH v5 0/7] Trace env variables in run_command()
  - From: Nguyễn Thái Ngọc Duy
- [PATCH v5 3/7] trace.c: move strbuf_release() out of print_trace_line()
  - From: Nguyễn Thái Ngọc Duy

Prev by Date: Re: Git uses wrong subkey for signing commits with GPG key
Next by Date: Re: [PATCH 1/2] parse-options: support --git-completion-helper
Previous by thread: [PATCH v5 3/7] trace.c: move strbuf_release() out of print_trace_line()
Next by thread: [PATCH v5 4/7] trace.c: introduce trace_run_command()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux