On Sat, Jan 13, 2018 at 01:49:42PM +0700, Nguyễn Thái Ngọc Duy wrote: > v4: > > - incorporates Jeff patches and moves them on top > - removes strbuf release from print_trace_line > - prints 'unset a b c' instead of 'unset a; unset b; unset c' > - squashes v3 3/4 and 4/4 and Junio's patch into 6/7 > - adds tests > - cwd is separated in 7/7 Thanks. Aside from the minor nit about argument parsing in test-run-command, this looks good to me. -Peff