On Sat, Jan 13, 2018 at 11:54 AM, Duy Nguyen <pclouds@xxxxxxxxx> wrote: > On Sat, Jan 13, 2018 at 5:54 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Jeff King <peff@xxxxxxxx> writes: >> >>> I also think this is a special case of a more general problem. FOO could >>> appear any number of times in the "env" array, as a deletion or with >>> multiple values. Our prep_childenv() would treat that as "last one >>> wins", I think. Could we just do the same here? >> >> Perhaps this should be squashed into the original 4/4 instead of >> being a separate patch. We'd probably want some sort of test, I >> wonder? Not tested at all beyond compiling... >> >> -- >8 -- >> Subject: [PATCH 7/4] run-command.c: don't be too cute in concatenate_env() >> >> Instead of relying on "sort" being stable to sort "unset VAR" >> immediately before "VAR=VAL" to remove the former, just pick the >> last manipulation for each VAR from the list of environment tweaks >> and show them in the output. > > This is not enough. No it is. I misunderstood string_list_insert() and my tests proved me wrong. Sorry for the noise. -- Duy
