> From: Junio C Hamano [mailto:gitster@xxxxxxxxx] On January 12, 2018 2:25 PM, Junio C Hamano wrote: > > From: "Randall S. Becker" <rsbecker@xxxxxxxxxxxxx> > > { > > - return convert_to_git(istate, path, NULL, 0, NULL, 0); > > + return convert_to_git(istate, path, NULL, 0, NULL, > SAFE_CRLF_FALSE); > > } > > I think this is being solved a bit differently with a1fbf854 > ("convert_to_git(): safe_crlf/checksafe becomes int conv_flags", 2018-01- > 06), and 0 becomes the right value to pass at this caller to say "I am passing > none of the flag bit". > > I am hoping that the series that ends at f3b11d54 ("convert: add support for > 'checkout-encoding' attribute", 2018-01-06) will be rerolled and hit 'master' > early in the next cycle. Got it. Will revert this one on my end. On a related too many warnings subject, hashmap.h has a variable unused (void *item). Is that addressed soon? If not, I can deal with it. Cheers, Randall (also, sorry about the other email address in use. It's the only way I can use send-email, fixing the annoying prior wrapping/tab/space garbage I had).
