On Fri, Jan 12, 2018 at 04:56:05PM +0700, Nguyễn Thái Ngọc Duy wrote: > We normally print full command line, including the program and its > argument. When git_cmd is set, we have a special code path to run the > right "git" program and child_process.argv[0] will not contain the > program name anymore. As a result, we print just the command > arguments. > > I thought it was a regression when the code was refactored and git_cmd > added, but apparently it's not. git_cmd mode was introduced before > tracing was added in 8852f5d704 (run_command(): respect GIT_TRACE - > 2008-07-07) so it's more like an oversight in 8852f5d704. > > Fix it, print the program name "git" in git_cmd mode. It's nice to have > now. But it will be more important later when we start to print env > variables too, in shell syntax. The lack of a program name would look > confusing then. Makes sense. Note that "git" isn't quoted here, but the rest of the arguments are. More on that in a minute. :) -Peff
