Re: [PATCH 00/15] git-note: A mechanisim for providing free-form after-the-fact annotations on commits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Sun, 27 May 2007, Johan Herland wrote:
> 
> I've been working on combining tag objects and --decorate into a useful
> proof-of-concept that provides the after-the-fact commit annotations I
> requested above, and here's the result:

Ok, looks fine to me. I do have a few questions:
 - why don't you just let people name their notes, the same way we name 
   tags (and then actually using it as the note name?)

   Putting them in the refs/notes/ filesystem by their SHA1 seems a bit 
   wasteful, and it would seem that it could be quite nice to name the 
   notes some way?

 - This will probably scale horribly badly if you have tens of thousands 
   of notes, even when they are packed. Do we care?

Other than that, it looks straightforward and sane.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux