2018-01-10 1:04 GMT+03:00 Junio C Hamano <gitster@xxxxxxxxx>: > Olga Telezhnaya <olyatelezhnaya@xxxxxxxxx> writes: > >> Rename some variables for easier reading. >> They point not to values, but to arrays. > > Once the code is written and people start to build on top, a change > like this is not worth the code churn, especially because there are > two equally valid schools of naming convention. > > - When you have an array, each of whose 20 slots holds a single > dosh, I would prefer to call the array dosh[20], not doshes[20], > so that I can refer to the seventh dosh as "dosh[7]". > > - If you more often refer to the array as a whole (than you refer > to individual elements) and want to stress the fact that the > array holds multiple elements in it, I can understand that you > may be tempted to call the whole array "doshes[]". > > So please drop this and other "rename variables" patches from the > series. > > OK, I will revert that. I have done this because it's hard for me to keep in mind that it's not just a simple pointer to a single value, and I tried to make the code more intuitive.
