On 01/09, Jonathan Tan wrote: > On Tue, 2 Jan 2018 16:18:11 -0800 > Brandon Williams <bmwill@xxxxxxxxxx> wrote: > > > diff --git a/transport.c b/transport.c > > index 63c3dbab9..2378dcb38 100644 > > --- a/transport.c > > +++ b/transport.c > > @@ -118,6 +118,7 @@ struct git_transport_data { > > struct child_process *conn; > > int fd[2]; > > unsigned got_remote_heads : 1; > > + enum protocol_version version; > > Should this be initialized to protocol_unknown_version? Right now, as > far as I can tell, it is zero-initialized, which means protocol_v0. I don't think it matters as the value isn't used until after the version has already been discovered. -- Brandon Williams