Re: [PATCH] Fix git-svn to handle svn not reporting the md5sum of a file, and test.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Wong wrote:
> A Large Angry SCM <gitzilla@xxxxxxxxx> wrote:
>> James Y Knight wrote:
>>> ---
>>> git-svn.perl                    |    2 +-
>>> t/t9112-git-svn-md5less-file.sh |   45
>>> +++++++++++++++++++++++++++++++++++++++
>>> 2 files changed, 46 insertions(+), 1 deletions(-)
>>> create mode 100755 t/t9112-git-svn-md5less-file.sh
>> [...]
>>
>> The new test fails here (Suse 9.3 fully patched) w/ the following:
>>
>> *** t9112-git-svn-md5less-file.sh ***
>> *   ok 1: load svn dumpfile
>> *   ok 2: initialize git-svn
>> * FAIL 3: fetch revisions from svn
>>         git-svn fetch
>> * failed 1 among 3 test(s)
>> make[1]: *** [t9112-git-svn-md5less-file.sh] Error 1
>
> I can't reproduce it here (on Debian Etch, SVN 1.4.2).  Can you run with
> the test with the -v switch?  Thanks.
>


~/GIT/git/t> sh ./t9112-git-svn-md5less-file.sh -v
* expecting success: svnadmin load /home/test/GIT/git/t/trash/svnrepo < dumpfile.svn
<<< Started new transaction, based on original revision 1
     * adding path : md5less-file ... done.

------- Committed revision 1 >>>

*   ok 1: load svn dumpfile

* expecting success: git-svn init file:///home/test/GIT/git/t/trash/svnrepo
*   ok 2: initialize git-svn

* expecting success: git-svn fetch
./test-lib.sh: line 141:  8163 Segmentation fault      git-svn fetch
* FAIL 3: fetch revisions from svn
        git-svn fetch

* failed 1 among 3 test(s)
~/GIT/git/t>


And here is the failing part of the test using sh -x:

+ test_expect_success 'fetch revisions from svn' 'git-svn fetch'
+ test 2 = 2
+ test_skip 'fetch revisions from svn' 'git-svn fetch'
++ expr ././t9112-git-svn-md5less-file.sh : '.*/\(t[0-9]*\)-[^/]*$'
+ this_test=t9112
++ expr 2 + 1
+ this_test=t9112.3
+ to_skip=
+ case "$to_skip" in
+ false
+ say 'expecting success: git-svn fetch'
+ echo '* expecting success: git-svn fetch'
* expecting success: git-svn fetch
+ test_run_ 'git-svn fetch'
+ eval 'git-svn fetch'
++ git-svn fetch
./test-lib.sh: line 141:  8276 Segmentation fault      git-svn fetch
+ eval_ret=139
+ return 0
+ '[' 0 = 0 -a 139 = 0 ']'
+ test_failure_ 'fetch revisions from svn' 'git-svn fetch'
++ expr 2 + 1
+ test_count=3
++ expr 0 + 1
+ test_failure=1
+ say 'FAIL 3: fetch revisions from svn'
+ echo '* FAIL 3: fetch revisions from svn'
* FAIL 3: fetch revisions from svn
+ shift
+ echo 'git-svn fetch'
+ sed -e 's/^/  /'
        git-svn fetch
+ test '' = ''
+ echo ''

This began after the 18bece4..99b5a79 update to master. Prior to that the svn tests were passing.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux