On Wednesday 03 January 2018 at 08:14 pm +0100, Ævar Arnfjörð Bjarmason wrote:
>
> On Wed, Jan 03 2018, Adam Dinwoodie jotted:
>
> > On Wednesday 03 January 2018 at 02:31 pm +0100, Ævar Arnfjörð Bjarmason wrote:
> >> Does the fixup above in <878tdm8k2d.fsf@xxxxxxxxxxxxxxxxxxx> work for
> >> you, i.e. changing $10 in the script to ${10}?
> >
> > This fixes some but not all of the failures: I'm now down from 42 to 24
> > failures.
> >
> > Updated verbose test output is at
> > https://gist.github.com/me-and/04443bcb00e12436f0eacce079b56d02
>
> Thanks lot, looking through our own commit logs I believe the rest
> should be fixed by this (prior art in 6fd1106aa4), it would be great if
> you could test it, I don't have access to a Windows machine:
>
> diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh
> index f985139b6f..5838fcb77d 100755
> --- a/t/t3070-wildmatch.sh
> +++ b/t/t3070-wildmatch.sh
> @@ -23,6 +23,15 @@ create_test_file() {
> *//*)
> return 1
> ;;
> + # On Windows, \ in paths is silently converted to /, which
> + # would result in the "touch" below working, but the test
> + # itself failing.
> + *\\*)
> + if ! test_have_prereq BSLASHPSPEC
> + then
> + return 1
> + fi
> + ;;
> # When testing the difference between foo/bar and foo/bar/ we
> # can't test the latter.
> */)
Confirmed this fixes all the outstanding test failures. Thank you!
