> On 31 Dec 2017, at 17:02, SZEDER Gábor <szeder.dev@xxxxxxxxx> wrote:
>
> Every once in a while our explicit .gitignore files get out of sync
> when our build process learns to create new artifacts, like test
> helper executables, but the .gitignore files are not updated
> accordingly.
>
> Use Travis CI to help catch such issues earlier: check that there are
> no untracked files at the end of any build jobs building Git (i.e. the
> 64 bit Clang and GCC Linux and OSX build jobs, plus the GETTEXT_POISON
> and 32 bit Linux build jobs) or its documentation, and fail the build
> job if there are any present.
>
> Signed-off-by: SZEDER Gábor <szeder.dev@xxxxxxxxx>
> ---
> ci/lib-travisci.sh | 10 ++++++++++
> ci/run-linux32-docker.sh | 2 ++
> ci/run-tests.sh | 2 ++
> ci/test-documentation.sh | 6 ++++++
> 4 files changed, 20 insertions(+)
>
> diff --git a/ci/lib-travisci.sh b/ci/lib-travisci.sh
> index 1543b7959..07f27c727 100755
> --- a/ci/lib-travisci.sh
> +++ b/ci/lib-travisci.sh
> @@ -67,6 +67,16 @@ skip_good_tree () {
> exit 0
> }
>
> +check_unignored_build_artifacts ()
> +{
> + ! git ls-files --other --exclude-standard --error-unmatch \
> + -- ':/*' 2>/dev/null ||
What does "-- ':/*'" do? Plus, why do you redirect stderr?
--
Both patches look good to me!
Thanks,
Lars
