On Fri, Dec 29, 2017 at 04:22:18PM +0100, lars.schneider@xxxxxxxxxxxx wrote:
> From: Lars Schneider <larsxschneider@xxxxxxxxx>
>
> Create a copy of an existing string and make all characters upper case.
> Similar xstrdup_tolower().
>
> This function is used in a subsequent commit.
>
> Signed-off-by: Lars Schneider <larsxschneider@xxxxxxxxx>
> ---
> strbuf.c | 13 +++++++++++++
> strbuf.h | 1 +
> 2 files changed, 14 insertions(+)
>
> diff --git a/strbuf.c b/strbuf.c
> index 323c49ceb3..54276e96e7 100644
> --- a/strbuf.c
> +++ b/strbuf.c
> @@ -760,6 +760,19 @@ char *xstrdup_tolower(const char *string)
> return result;
> }
>
> +char *xstrdup_toupper(const char *string)
> +{
> + char *result;
> + size_t len, i;
> +
> + len = strlen(string);
> + result = xmallocz(len);
> + for (i = 0; i < len; i++)
> + result[i] = toupper(string[i]);
> + result[i] = '\0';
^^^^^^^^^^^^^^^^
Isn't this already done by xmallocz()
> + return result;
> +}
> +
> char *xstrvfmt(const char *fmt, va_list ap)
> {
> struct strbuf buf = STRBUF_INIT;
> diff --git a/strbuf.h b/strbuf.h
> index 0a74acb236..2bc148526f 100644
> --- a/strbuf.h
> +++ b/strbuf.h
> @@ -616,6 +616,7 @@ __attribute__((format (printf,2,3)))
> extern int fprintf_ln(FILE *fp, const char *fmt, ...);
>
> char *xstrdup_tolower(const char *);
> +char *xstrdup_toupper(const char *);
>
> /**
> * Create a newly allocated string using printf format. You can do this easily
> --
> 2.15.1
>
