Duy Nguyen <pclouds@xxxxxxxxx> writes: >> Duy, what am I missing here? > > The problem is there, it's just easier to see or verify with > symlinks. Below is my test patch on top of your original one. Two > points: > > - if you look at the test-dump-untracked-cache output, you can see the > saved cache is wrong. The line > > /one/ 0000000000000000000000000000000000000000 recurse valid > > should not be there because that implies that cached travesal of > root includes the directory "one" which does not exist on disk > anymore. With the fix, this line is gone. Nice. > - We silently ignore opendir() error, the changes in dir.c shows this > ... > Report opendir() errors is a good and should be done regardless (i'm > just not sure if it should be a fatal error or a warning like this, I > guess die() is a bit too much). Thanks; I agree that it definitely would be a good change to issue a warning there.
