On Dec 27, 2017, at 06:35, Carl Baldwin <carl@xxxxxxxxxxxxx> wrote: > > On Sun, Dec 24, 2017 at 10:52:15PM -0500, Theodore Ts'o wrote: >> >> My experience, from seeing these much more complex use cases --- >> starting with something as simple as the Linux Kernel Stable Kernel >> Series, and extending to something much more complex such as the >> workflow that is used to support a Google Kernel Rebase, is that using >> just a simple extra "Replaces" pointer in the commit header is not >> nearly expressive enough. And, if you make it a core part of the >> commit data structure, there are all sorts of compatibility headaches >> with older versions of git that wouldn't know about it. And if it > > The more I think about this, the less I worry. Be sure that you're using > >> then turns out it's not sufficient more the more complex workflows >> *anyway*, maybe adding a new "replace" pointer in the core git data >> structures isn't worth it. It might be that just keeping such things >> as trailers in the commit body might be the better way to go. > > It doesn't need to be everything to everyone to be useful. I hope to > show in this thread that it is useful enough to be a compelling addition > to git. I think I've also shown that it could be used as a part of your > more complex workflow. Maybe even a bigger part of it than you had > realized. I think the reasoning behind Theo's words is that it would be better to first implement the commit relationship tracking as an add-in which uses commit messages for data storage, then evaluate its usefulness when it's actually available (including extensions to gitk and stuff to support the new metadata), and then it could be moved into core git data structures, when it has proven itself useful. It's not a trivial feature which warrants immediate addition to git and its design can change when faced with real- world use-cases, so it would be bad for compatibility to rush its addition. Storage location for metadata seems to be an implementation detail which could be technically changed more or less easily. But it's much easier to ignore a trailer in commit message in the favor of a commit header field than to replace a deprecated commit header field with a better one, which could cause massive headache for all git repositories in the world.
