Re: [PATCH 6/6] wildmatch test: create & test files on disk in addition to in-memory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 24.12.2017 um 12:06 schrieb Ævar Arnfjörð Bjarmason:
On Sun, Dec 24 2017, Johannes Sixt jotted:
Am 23.12.2017 um 22:30 schrieb Ævar Arnfjörð Bjarmason:
+				printf '%s' '$text' >expect &&

There are no single-quotes in any $text instances, right?

There's not, but maybe we should be more careful here and use here-docs.

Unless it is essential to test the single-quote case, we need not complicate the code. I just wanted to rise awareness. If a problematic test case is introduced, it will be noticed soon enough. It's not that we deal with unknown input here.

-- Hannes



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux