"phillip.wood@xxxxxxxxxxxx" <phillip.wood@xxxxxxxxxxxx> writes: >>----Original Message---- >>From: johannes.schindelin@xxxxxx >>Date: 22/12/2017 11:50 >>To: <git@xxxxxxxxxxxxxxx> >>Cc: "Junio C Hamano"<gitster@xxxxxxxxx>, "Phillip Wood"<phillip. > wood@xxxxxxxxxxxxx>, "Kaartic Sivaraam"<kaartic.sivaraam@xxxxxxxxx> >>Subj: [PATCH] sequencer: assign only free()able strings to gpg_sign >> >>The gpg_sign member of the replay_opts structure is of type `char *`, >>meaning that the sequencer deems the string to which gpg_sign points > to >>be under its custody, i.e. it needs to be free()d by the sequencer. >> >>Therefore, let's only assign malloc()ed buffers to it. >> >>Reported-by: Kaartic Sivaraam <kaartic.sivaraam@xxxxxxxxx> >>Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> >>--- >> >> Phillip, if you want to squash these changes into your patches, >> I'd totally fine with that. >> > > Hi Johannes, thanks for putting this together, the patch it fixes is > already in next so I think it'd be best to leave this one separate. I > wonder if it would be worth adding another test, see below. Thanks, both. Let's queue this on top as a fix-up.
