Hi Phillip, On Fri, 22 Dec 2017, phillip.wood@xxxxxxxxxxxx wrote: > I thought the bug could be triggered when commit.gpgsign was true and > it was not overriden on the commandline, is it worth adding a test for > that? Everybody working with extensive test suites seems to write/blog these days that you have to be careful to test meaningfully, i.e. you need to avoid making running the test suite so expensive that developers start to avoid running it. In that light, what do we want to test? If we want to verify that the gpg_sign is correctly allocated before it is free()d, then the test case I added *already* covers it, and another test case would only increase the runtime of the test suite (which, as I hinted above, I deem a bad thing). So I'm really in favor of keeping the tests concise. Ciao, Dscho
