Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > I started by trying to come up with something generic which would handle > future submodules, i.e.: > > git submodule foreach 'git ls-files' I am not all that interested in that. The hardcoded list I felt disturbing was not "what are the submodules we want to include?", but "what are the files from sha1dc submodule we use?". IOW, I was more wondering about these selective copies: ... + @cp sha1collisiondetection/LICENSE.txt \ + $(GIT_TARNAME)/sha1collisiondetection/ + @cp sha1collisiondetection/LICENSE.txt \ + $(GIT_TARNAME)/sha1collisiondetection/ + @cp sha1collisiondetection/lib/sha1.[ch] \ + $(GIT_TARNAME)/sha1collisiondetection/lib/ + @cp sha1collisiondetection/lib/ubc_check.[ch] \ + $(GIT_TARNAME)/sha1collisiondetection/lib/ ... As we are assuming that DC_SHA1_SUBMODULE users are not doing the make dist from a tarball extract, wouldn't something along the lines of git -C sha1collisiondetection archive HEAD | \ $(TAR) Cxf $(GIT_TARNAME)/sha1collisiondetection - be a better way to go?
