Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> writes: > On 13/12/17 01:06, Junio C Hamano wrote: > >> We may probably want to redirect the output of underlying grep to >> /dev/null in test_i18ngrep to make this kind of misuse easier to >> spot. > > I have test-suite failures on the 'pu' branch for t4151-am-abort.sh > (#3 and #6) and t5536-fetch-conflicts.sh (#3 and #6-7), which on a > very quick inspection seem to be due to this (ie your SQUASH commit > e5c5e24ad9). Yup, sorry for leaving it broken this morning. I re-pushed after dropping the /dev/null experiment to fix it. In the longer term, I think we should make sure that output from test_i18ngrep is never used (i.e. t4151 etc. must be fixed), though.